Bug 169354

Summary: [Modern Media Controls] Fullscreen controls during Live Broadcast is completely broken
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews114 for mac-elcapitan
none
Patch none

Description Antoine Quint 2017-03-08 05:47:15 PST
For Live Broadcast in fullscreen, we should disable the rewind and fast forward button and ensure we display the "Live Broadcast" status text instead of the scrubber.
Comment 1 Antoine Quint 2017-03-08 05:47:30 PST
<rdar://problem/30636370>
Comment 2 Antoine Quint 2017-03-08 05:48:43 PST
*** Bug 168810 has been marked as a duplicate of this bug. ***
Comment 3 Antoine Quint 2017-03-14 09:24:46 PDT
Created attachment 304387 [details]
Patch
Comment 4 Build Bot 2017-03-14 10:29:32 PDT
Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3321855

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html
Comment 5 Build Bot 2017-03-14 10:29:34 PDT
Created attachment 304394 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-03-14 10:32:20 PDT
Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3321856

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html
Comment 7 Build Bot 2017-03-14 10:32:23 PDT
Created attachment 304395 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-03-14 10:37:59 PDT
Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3321852

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html
Comment 9 Build Bot 2017-03-14 10:38:02 PDT
Created attachment 304396 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Antoine Quint 2017-03-14 10:43:25 PDT
Created attachment 304397 [details]
Patch
Comment 11 Dean Jackson 2017-03-14 10:59:40 PDT
Comment on attachment 304397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304397&action=review

> Source/WebCore/Modules/modern-media-controls/media/seek-support.js:51
> +        this.control.enabled = this.mediaController.media.duration !== Number.POSITIVE_INFINITY;

It might be nice to have a isLiveStream() helper to make it clear what you're testing, in case you have to search for it later.
Comment 12 WebKit Commit Bot 2017-03-14 11:29:18 PDT
Comment on attachment 304397 [details]
Patch

Clearing flags on attachment: 304397

Committed r213920: <http://trac.webkit.org/changeset/213920>
Comment 13 WebKit Commit Bot 2017-03-14 11:29:23 PDT
All reviewed patches have been landed.  Closing bug.