| Summary: | font-style needs a new CSSValue to make CSSRule.cssText work correctly | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, dino, hyatt, jonlee, koivisto, mmaxfield, rniwa, simon.fraser, thorton | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 162815, 173970 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Myles C. Maxfield
2017-03-06 21:07:18 PST
Also because "oblique" and "italic" probably should result in different variation axes being used. Created attachment 305174 [details]
Patch
Comment on attachment 305174 [details] Patch Attachment 305174 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3393453 Number of test failures exceeded the failure limit. Created attachment 305178 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 305230 [details]
Patch
Comment on attachment 305230 [details] Patch Attachment 305230 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3398371 New failing tests: editing/execCommand/italicizeByCharacter.html editing/execCommand/format-block-contenteditable-false.html editing/execCommand/toggle-link-win.html editing/execCommand/toggle-compound-styles.html editing/style/toggle-style-bold-italic-mixed-editability.html editing/execCommand/toggle-link-mac.html fast/events/before-input-prevent-biu.html editing/style/toggle-style-bold-italic.html editing/execCommand/toggle-unlink-mac.html editing/execCommand/toggle-style-3.html editing/apply-style-iframe-crash.html editing/style/typing-style-003.html editing/style/push-down-inline-styles.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/style-3681552-fix-002.html editing/style/remove-styled-element-with-style-span.html editing/style/push-down-implicit-styles-around-list-win.html editing/style/inline-style-extend-run.html editing/style/style-text-node-without-editable-parent.html Created attachment 305240 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 305230 [details] Patch Attachment 305230 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3398606 New failing tests: editing/execCommand/italicizeByCharacter.html editing/execCommand/format-block-contenteditable-false.html editing/execCommand/toggle-compound-styles.html editing/style/toggle-style-bold-italic-mixed-editability.html editing/style/inline-style-extend-run.html editing/execCommand/toggle-link-win.html editing/style/toggle-style-bold-italic.html editing/style/style-3681552-fix-002.html editing/execCommand/toggle-style-3.html editing/apply-style-iframe-crash.html editing/style/typing-style-003.html editing/style/push-down-inline-styles.html editing/style/remove-styled-element-with-style-span.html Created attachment 305247 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 305230 [details] Patch Attachment 305230 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3398743 New failing tests: editing/execCommand/italicizeByCharacter.html editing/execCommand/format-block-contenteditable-false.html fast/events/before-input-prevent-biu.html editing/style/toggle-style-bold-italic-mixed-editability.html editing/execCommand/toggle-link-mac.html editing/execCommand/toggle-link-win.html editing/style/typing-style-003.html editing/execCommand/toggle-unlink-mac.html editing/execCommand/toggle-style-3.html editing/apply-style-iframe-crash.html editing/style/toggle-style-bold-italic.html editing/style/push-down-inline-styles.html editing/style/remove-styled-element-with-style-span.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/style-3681552-fix-002.html editing/execCommand/toggle-compound-styles.html editing/style/push-down-implicit-styles-around-list-win.html editing/style/inline-style-extend-run.html editing/style/style-text-node-without-editable-parent.html Created attachment 305248 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 305250 [details]
WIP
Created attachment 305268 [details]
Patch
Comment on attachment 305268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305268&action=review r=me > Source/WebCore/css/CSSFontStyleValue.h:30 > +#include "FontSelectionAlgorithm.h" Don't think you need this include, right? > Source/WebCore/css/CSSFontValue.cpp:48 > - if (weight) { > + if (stretch) { Hah! Comment on attachment 305268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305268&action=review >> Source/WebCore/css/CSSFontStyleValue.h:30 >> +#include "FontSelectionAlgorithm.h" > > Don't think you need this include, right? It's needed for italicValue() Committed r214359: <http://trac.webkit.org/changeset/214359> |