Bug 169233

Summary: Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit2Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz, ryanhaddad, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168919
Attachments:
Description Flags
Proposed patch
ap: review+
Updated patch
none
Updated patch none

Aakash Jain
Reported 2017-03-06 16:02:54 PST
WebKit2 for iOS should enable SUPPORTS_TEXT_BASED_API.
Attachments
Proposed patch (10.12 KB, patch)
2017-03-06 16:11 PST, Aakash Jain 		ap: review+
DetailsFormatted DiffDiff
Updated patch (10.08 KB, patch)
2017-03-06 19:53 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (10.21 KB, patch)
2017-03-06 20:08 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-03-06 16:11:03 PST
Created attachment 303579 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2017-03-06 16:30:48 PST
Comment on attachment 303579 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=303579&action=review > Source/WebKit2/Configurations/Base.xcconfig:119 > +OTHER_TAPI_FLAGS = -x objective-c++ -std=c++11; Do we want -fno-rtti here, to match WebKitLegacy?
Aakash Jain
Comment 3 2017-03-06 19:53:36 PST
Created attachment 303605 [details] Updated patch > Do we want -fno-rtti here, to match WebKitLegacy? Added -fno-rtti. Will land soon.
Aakash Jain
Comment 4 2017-03-06 20:08:41 PST
Created attachment 303608 [details] Updated patch Added [sdk=iphone*] in xcconfig. Previous patch was enabling it for all platforms. Please review again.
Alexey Proskuryakov
Comment 5 2017-03-06 22:29:05 PST
Comment on attachment 303608 [details] Updated patch Good catch.
WebKit Commit Bot
Comment 6 2017-03-06 23:19:55 PST
Comment on attachment 303608 [details] Updated patch Clearing flags on attachment: 303608 Committed r213504: <http://trac.webkit.org/changeset/213504>
WebKit Commit Bot
Comment 7 2017-03-06 23:19:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.