Bug 169232

Summary:

[WebCrypto] Make sure all CryptoKey classes are structured clonable

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, bfulgham, commit-queue, jiewen_tan, jsbell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

166746

Attachments:

Description	Flags
Patch	none

Description Jiewen Tan 2017-03-06 15:59:37 PST

Make CryptoKeyEC structured clonable.

Comment 1 Jiewen Tan 2017-03-06 16:00:52 PST

<rdar://problem/23789585>

Comment 2 Jiewen Tan 2017-03-09 00:32:13 PST

(In reply to comment #1)
> <rdar://problem/23789585>

This radar is faked.

Comment 3 Jiewen Tan 2017-03-09 00:33:06 PST

We should make sure all CryptoKey classes are structured clonable.

Comment 4 Jiewen Tan 2017-03-09 00:35:36 PST

This includes CryptoKeyAES, CryptoKeyHMAC, CryptoKeyEE, CryptoKeyRSA and CryptoKeyRaw.

Comment 5 Jiewen Tan 2017-03-09 00:37:06 PST

For all CryptoKey, we should make sure they have move constructors.

Comment 6 Jiewen Tan 2017-03-16 20:47:00 PDT

<rdar://problem/31106660>

Comment 7 Jiewen Tan 2017-03-16 20:57:41 PDT

Created attachment 304747 [details]
Patch

Comment 8 WebKit Commit Bot 2017-03-16 20:59:50 PDT

Attachment 304747 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:196:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:197:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Brent Fulgham 2017-03-17 13:18:29 PDT

Comment on attachment 304747 [details]
Patch

r=me.

Comment 10 Jiewen Tan 2017-03-17 13:48:59 PDT

Comment on attachment 304747 [details]
Patch

Thanks Brent for r+ my patch.

Comment 11 WebKit Commit Bot 2017-03-17 14:18:46 PDT

Comment on attachment 304747 [details]
Patch

Clearing flags on attachment: 304747

Committed r214122: <http://trac.webkit.org/changeset/214122>

Comment 12 WebKit Commit Bot 2017-03-17 14:18:50 PDT

All reviewed patches have been landed.  Closing bug.