Bug 169204

Summary:

Web Inspector: REGRESSION(r213149): scope bar items in elements sidebar have wrong padding/margin

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, hyatt, inspector-bugzilla-changes, joepeck, mattbaker, nvasilyev, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
SCREENSHOT	none
Patch	none
[Image] After Patch is applied	none

Blaze Burg

Reported 2017-03-06 09:56:05 PST

Created attachment 303521 [details] SCREENSHOT Not sure how this regressed so bad. Other scope bars are not affected.

Attachments
SCREENSHOT (48.88 KB, image/png) 2017-03-06 09:56 PST, Blaze Burg	no flags	Details
Patch (2.27 KB, patch) 2017-03-10 13:48 PST, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (33.09 KB, image/png) 2017-03-10 14:10 PST, Devin Rousso	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-03-06 09:56:25 PST

<rdar://problem/30871692>

Nikita Vasilyev

Comment 2 2017-03-06 11:07:05 PST

The details sidebar (the right sidebar) in Resources and Debugger is also affected. This happened once before over a year ago. I believe last time it was related to a flexbox change in WebKit.

Matt Baker

Comment 3 2017-03-08 16:37:03 PST

Looks like this broke somewhere in: http://trac.webkit.org/log/trunk/?mode=follow_copy&rev=213149&stop_rev=213115

Matt Baker

Comment 4 2017-03-08 16:38:56 PST

Regressed in https://bugs.webkit.org/show_bug.cgi?id=168657.

Blaze Burg

Comment 5 2017-03-08 16:56:45 PST

(In reply to comment #4) > Regressed in https://bugs.webkit.org/show_bug.cgi?id=168657. Not surprising. Can you take a look and see if our CSS is wrong?

Devin Rousso

Comment 6 2017-03-10 13:48:49 PST

Created attachment 304068 [details] Patch

Devin Rousso

Comment 7 2017-03-10 14:10:12 PST

Created attachment 304074 [details] [Image] After Patch is applied

Blaze Burg

Comment 8 2017-03-10 14:37:47 PST

Comment on attachment 304068 [details] Patch r=me

Nikita Vasilyev

Comment 9 2017-03-10 14:52:46 PST

Comment on attachment 304068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304068&action=review > Source/WebInspectorUI/ChangeLog:16 > + <select> from showing. Nice!

WebKit Commit Bot

Comment 10 2017-03-10 16:45:42 PST

Comment on attachment 304068 [details] Patch Clearing flags on attachment: 304068 Committed r213734: <http://trac.webkit.org/changeset/213734>

WebKit Commit Bot

Comment 11 2017-03-10 16:45:48 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.