Summary: | Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, cgarcia, commit-queue, ddkilzer, dean_johnson, Hironori.Fujii, lforschler, ryanhaddad, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 168939 | ||||||||||
Bug Blocks: | 171847 | ||||||||||
Attachments: |
|
Description
Jonathan Bedard
2017-02-27 16:22:57 PST
*** Bug 168946 has been marked as a duplicate of this bug. *** Created attachment 309105 [details]
Patch
Comment on attachment 309105 [details]
Patch
CQ-ing since some archiving code needed to ensure this patch works internally has not yet been landed.
Created attachment 309169 [details]
Patch
Comment on attachment 309105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309105&action=review > Tools/Scripts/build-webkit:307 > +if (!-e $command[0]) { > + die "build-imagediff script not found"; > +} This should be done only for ports that use this script to build image diff. Comment on attachment 309169 [details] Patch CQ-ing this again, see Comment 4. Comment on attachment 309169 [details]
Patch
Internal infrastructure has been updated. This patch should be ready to go.
Comment on attachment 309169 [details]
Patch
r=me
Comment on attachment 309169 [details] Patch Clearing flags on attachment: 309169 Committed r216260: <http://trac.webkit.org/changeset/216260> All reviewed patches have been landed. Closing bug. Reverted r216260 for reason: Breaks internal iOS testers Committed r216271: <http://trac.webkit.org/changeset/216271> Created attachment 309217 [details]
Patch
Comment on attachment 309217 [details]
Patch
No change to patch. Just added David Kilzer as the reviewer. Will be landing again shortly now that Internal bots have been fixed.
Comment on attachment 309217 [details]
Patch
Confirmed that the Internal bots fix worked. Sending to commit queue.
Comment on attachment 309217 [details] Patch Clearing flags on attachment: 309217 Committed r216288: <http://trac.webkit.org/changeset/216288> All reviewed patches have been landed. Closing bug. |