Bug 168945

Summary: Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, cgarcia, commit-queue, ddkilzer, dean_johnson, fujii.hironori, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168939    
Bug Blocks: 171847    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2017-02-27 16:22:57 PST
Webkitpy should use the ImageDiff that is built by the host SDK rather than on built with the SDK being tested.
Attachments
Patch (34.13 KB, patch)
2017-05-04 14:22 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (32.69 KB, patch)
2017-05-05 08:22 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (32.68 KB, patch)
2017-05-05 15:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-27 16:23:59 PST
<rdar://problem/30745695>
Jonathan Bedard
Comment 2 2017-05-04 13:45:16 PDT
*** Bug 168946 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 3 2017-05-04 14:22:38 PDT
Created attachment 309105 [details] Patch
Jonathan Bedard
Comment 4 2017-05-04 14:25:28 PDT
Comment on attachment 309105 [details] Patch CQ-ing since some archiving code needed to ensure this patch works internally has not yet been landed.
Jonathan Bedard
Comment 5 2017-05-05 08:22:22 PDT
Created attachment 309169 [details] Patch
Carlos Garcia Campos
Comment 6 2017-05-05 08:23:56 PDT
Comment on attachment 309105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309105&action=review > Tools/Scripts/build-webkit:307 > +if (!-e $command[0]) { > + die "build-imagediff script not found"; > +} This should be done only for ports that use this script to build image diff.
Jonathan Bedard
Comment 7 2017-05-05 08:34:25 PDT
Comment on attachment 309169 [details] Patch CQ-ing this again, see Comment 4.
Jonathan Bedard
Comment 8 2017-05-05 10:05:46 PDT
Comment on attachment 309169 [details] Patch Internal infrastructure has been updated. This patch should be ready to go.
David Kilzer (:ddkilzer)
Comment 9 2017-05-05 12:15:40 PDT
Comment on attachment 309169 [details] Patch r=me
WebKit Commit Bot
Comment 10 2017-05-05 12:26:40 PDT
Comment on attachment 309169 [details] Patch Clearing flags on attachment: 309169 Committed r216260: <http://trac.webkit.org/changeset/216260>
WebKit Commit Bot
Comment 11 2017-05-05 12:26:44 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 12 2017-05-05 13:52:39 PDT
Reverted r216260 for reason: Breaks internal iOS testers Committed r216271: <http://trac.webkit.org/changeset/216271>
Jonathan Bedard
Comment 13 2017-05-05 15:06:42 PDT
Created attachment 309217 [details] Patch
Jonathan Bedard
Comment 14 2017-05-05 15:07:45 PDT
Comment on attachment 309217 [details] Patch No change to patch. Just added David Kilzer as the reviewer. Will be landing again shortly now that Internal bots have been fixed.
Jonathan Bedard
Comment 15 2017-05-05 15:36:33 PDT
Comment on attachment 309217 [details] Patch Confirmed that the Internal bots fix worked. Sending to commit queue.
WebKit Commit Bot
Comment 16 2017-05-05 15:56:32 PDT
Comment on attachment 309217 [details] Patch Clearing flags on attachment: 309217 Committed r216288: <http://trac.webkit.org/changeset/216288>
WebKit Commit Bot
Comment 17 2017-05-05 15:56:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.