Bug 168919

Summary:

Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, juergen, lforschler, mitz, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=169233

Attachments:

Description	Flags
Proposed patch	thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Updated patch	none
Updated patch	none

Aakash Jain

Reported 2017-02-27 11:16:41 PST

WebKit for iOS should enable SUPPORTS_TEXT_BASED_API.

Attachments
Proposed patch (4.63 KB, patch) 2017-02-27 11:22 PST, Aakash Jain	thorton: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (840.71 KB, application/zip) 2017-02-27 12:25 PST, Build Bot	no flags	Details
Updated patch (3.10 KB, patch) 2017-02-27 13:48 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (4.64 KB, patch) 2017-02-27 13:52 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-27 11:22:04 PST

Created attachment 302857 [details] Proposed patch

Tim Horton

Comment 2 2017-02-27 11:24:14 PST

Comment on attachment 302857 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review > Source/WebKit/ChangeLog:3 > + Enable SUPPORTS_TEXT_BASED_API in WebKit for iOS WebKitLegacy, specifically, right?

Build Bot

Comment 3 2017-02-27 12:25:54 PST

Comment on attachment 302857 [details] Proposed patch Attachment 302857 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3203951 New failing tests: scrollingcoordinator/ios/non-stable-viewport-scroll.html

Build Bot

Comment 4 2017-02-27 12:25:57 PST

Created attachment 302863 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Alexey Proskuryakov

Comment 5 2017-02-27 12:42:13 PST

Comment on attachment 302857 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:3341 > + shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi"; Two spaces here. > Source/WebKit/mac/migrate-headers.sh:35 > +if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs" -o "${ACTION}" = "installapi" ]; then Two spaces here.

Aakash Jain

Comment 6 2017-02-27 13:48:05 PST

Created attachment 302868 [details] Updated patch Removed extra spaces.

Aakash Jain

Comment 7 2017-02-27 13:52:43 PST

Created attachment 302870 [details] Updated patch

WebKit Commit Bot

Comment 8 2017-02-27 14:56:18 PST

Comment on attachment 302870 [details] Updated patch Clearing flags on attachment: 302870 Committed r213096: <http://trac.webkit.org/changeset/213096>

WebKit Commit Bot

Comment 9 2017-02-27 14:56:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.