Bug 168863 – REGRESSION(r212853): Comparisons to baseline no longer shows up

• Component: Perf Dashboard
• Status: RESOLVED FIXED

[Ryosuke Niwa]

After https://trac.webkit.org/changeset/212853, we no longer see comparisons to baseline/target.

[Ryosuke Niwa]

Created attachment 302732 [details]
Fixes the bug

[Joseph Pecoraro]

Comment on attachment 302732 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=302732&action=review

rs=me

> Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1
> +(() => {

Is this scoping necessary?

> Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118
>          }

Style: You normally use semicolons.

[Ryosuke Niwa]

(In reply to comment #2)
> Comment on attachment 302732 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302732&action=review
> 
> rs=me
> 
> > Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1
> > +(() => {
> 
> Is this scoping necessary?

Yeah, it was a bunch of functions & variables to the global scope because it's loaded in the browser.

> > Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118
> >          }
> 
> Style: You normally use semicolons.

Oops, fixed.

Thanks for the review!

[Ryosuke Niwa]

Committed r212997: <http://trac.webkit.org/changeset/212997>