Bug 168813

Summary: New sampling algorithm shows very few points when zoomed out
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, joepeck, jonlee, rniwa, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168693    
Bug Blocks:    
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug saam: review+

Ryosuke Niwa
Reported 2017-02-23 18:12:32 PST
Turns out the new sampling algorithm introduced in https://trac.webkit.org/changeset/212853 can hide vast majority of points when zoomed out to a large time range because then almost all points are fall below the threshold.
Attachments
Fixes the bug (13.63 KB, patch)
2017-02-23 20:37 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (15.98 KB, patch)
2017-02-23 22:43 PST, Ryosuke Niwa 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-23 20:37:32 PST
Created attachment 302634 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2017-02-23 21:23:19 PST
Comment on attachment 302634 [details] Fixes the bug Nope, this still has a pathology where if the graph becomes more dense because bots become healthier, cycle time improved, etc... then we can simply drop an entire section of data points :(
Ryosuke Niwa
Comment 3 2017-02-23 22:43:55 PST
Created attachment 302645 [details] Fixes the bug
Saam Barati
Comment 4 2017-02-23 22:55:14 PST
Comment on attachment 302645 [details] Fixes the bug r=me
Ryosuke Niwa
Comment 5 2017-02-23 22:58:52 PST
Committed r212946: <http://trac.webkit.org/changeset/212946>
Note You need to log in before you can comment on or make changes to this bug.