Bug 168323

Summary: [CMake] build-webkit should allow building with the default cmake configuration
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, dbates, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168318
Bug Depends on:    
Bug Blocks: 168321    
Attachments:
Description Flags
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2017-02-14 08:24:36 PST
When using the build-webkit script its currently not possible to use the default features enabled on the cmake configuration for the port. The --minimal option disabled all optional features. I propose adding a --default option that build the CMake port without specifying any value for the features, that way the default value from the cmake config will be used. This will be needed for the new bots we plan to add on bug 168321
Attachments
Patch (2.49 KB, patch)
2017-02-14 08:40 PST, Carlos Alberto Lopez Perez
no flags
Patch (2.67 KB, patch)
2017-02-14 09:43 PST, Carlos Alberto Lopez Perez
no flags
Michael Catanzaro
Comment 1 2017-02-14 08:30:22 PST
You need to come up with a better name than --default. We can't have a --default flag that changes all the arguments to something that's not default for build-webkit, that would be super confusing. :) Maybe --disable-developer-options?
Carlos Alberto Lopez Perez
Comment 2 2017-02-14 08:40:00 PST
Carlos Alberto Lopez Perez
Comment 3 2017-02-14 09:43:16 PST
Created attachment 301515 [details] Patch Use --default-cmake-features for this
Michael Catanzaro
Comment 4 2017-02-14 09:48:22 PST
Comment on attachment 301515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301515&action=review This is great! Now build-webkit will actually be useful. :) > Tools/Scripts/build-webkit:55 > +my $defaultCmakeFeatures = 0; $defaultCMakeFeatures
Carlos Alberto Lopez Perez
Comment 5 2017-02-14 10:09:23 PST
Note You need to log in before you can comment on or make changes to this bug.