Bug 168318

Summary: [CMake] build-webkit should print the cmake command executed
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bugs-noreply, commit-queue, dbates, ggaren, lforschler, mcatanzaro, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168323
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2017-02-14 07:36:50 PST
When using the script build-webkit, is not obvious at all what we end passing to the CMake build system. On one hand I think it should be easy to see that info. On the other hand, I find this info very valuable to be fully aware of what options we (and the bots) build and how (actually I'm really surprised to discover that on the GTK+ port we are passing more than 90 parameters to CMake on the release build) So I propose that we print the CMake commands that we are going to run on stdout. I think this don't adds unneeded extra noise, it only prints one extra line (a long one when starting from a clean build state) each time you run the build-webkit script.
Attachments
Patch (2.54 KB, patch)
2017-02-14 07:46 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-02-14 07:46:50 PST
Created attachment 301499 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-14 08:48:28 PST
Comment on attachment 301499 [details] Patch Clearing flags on attachment: 301499 Committed r212298: <http://trac.webkit.org/changeset/212298>
WebKit Commit Bot
Comment 3 2017-02-14 08:48:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.