Bug 167964

Summary: Object.getPrototypeOf(NodeFilter) should be Function.prototype, not Object.prototype
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, ggaren, rniwa, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/heycam/webidl/issues/96
See Also: https://bugs.webkit.org/show_bug.cgi?id=160555
Bug Depends on: 168026    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Patch none

Chris Dumez
Reported 2017-02-07 16:20:08 PST
NodeFilter's [[Prototype]] should be %FunctionPrototype%, not %ObjectPrototype%. The Web IDL specification on this has changed recently: - https://heycam.github.io/webidl/#interface-object
Attachments
WIP Patch (4.94 KB, patch)
2017-02-07 16:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (987.72 KB, application/zip)
2017-02-07 17:56 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.64 MB, application/zip)
2017-02-07 18:05 PST, Build Bot 		no flags
Details
Patch (9.13 KB, patch)
2017-02-09 09:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-02-07 16:49:51 PST
Created attachment 300858 [details] WIP Patch
Build Bot
Comment 2 2017-02-07 17:56:53 PST
Comment on attachment 300858 [details] WIP Patch Attachment 300858 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3022402 New failing tests: http/tests/security/cross-frame-access-put.html
Build Bot
Comment 3 2017-02-07 17:56:57 PST
Created attachment 300866 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-02-07 18:05:19 PST
Comment on attachment 300858 [details] WIP Patch Attachment 300858 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3022409 New failing tests: http/tests/security/cross-frame-access-put.html
Build Bot
Comment 5 2017-02-07 18:05:22 PST
Created attachment 300870 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Chris Dumez
Comment 6 2017-02-09 09:57:20 PST
Created attachment 301053 [details] Patch
WebKit Commit Bot
Comment 7 2017-02-09 10:56:00 PST
Comment on attachment 301053 [details] Patch Clearing flags on attachment: 301053 Committed r211970: <http://trac.webkit.org/changeset/211970>
WebKit Commit Bot
Comment 8 2017-02-09 10:56:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.