| Summary: | Migrate ComplexTextController to use platform-independent types | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, dino, fred.wang, jonlee, rniwa, simon.fraser, thorton | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 167566 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Myles C. Maxfield
2017-02-04 01:03:37 PST
Created attachment 300607 [details]
Patch
Comment on attachment 300607 [details] Patch Attachment 300607 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3002808 New failing tests: fast/text/complex-text-opacity.html Created attachment 300618 [details]
Archive of layout-test-results from ews102 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 300607 [details] Patch Attachment 300607 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3002813 New failing tests: fast/text/complex-text-opacity.html Created attachment 300619 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 300607 [details] Patch Attachment 300607 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3002881 New failing tests: fast/text/complex-text-opacity.html Created attachment 300620 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 300639 [details]
Patch
Created attachment 300740 [details]
Update types
Created attachment 300749 [details]
Update types
Comment on attachment 300749 [details] Update types View in context: https://bugs.webkit.org/attachment.cgi?id=300749&action=review Looks good to me! r=me. > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:178 > + float x = h; Isn't CGFloat a double in 64-bit builds? > Source/WebCore/platform/graphics/mac/ComplexTextController.h:25 > +#pragma once Yay! Comment on attachment 300749 [details] Update types View in context: https://bugs.webkit.org/attachment.cgi?id=300749&action=review >> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:178 >> + float x = h; > > Isn't CGFloat a double in 64-bit builds? Yep. Comment on attachment 300749 [details] Update types Clearing flags on attachment: 300749 Committed r211765: <http://trac.webkit.org/changeset/211765> All reviewed patches have been landed. Closing bug. |