Bug 167833 - Migrate ComplexTextController to use platform-independent types
Summary: Migrate ComplexTextController to use platform-independent types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 167566
  Show dependency tree / graph
 
Reported: 2017-02-04 01:03 PST by Myles C. Maxfield
Modified: 2017-02-06 23:51 PST (History)
9 users (show)

See Also:

Attachments
Patch (144.88 KB, patch)
2017-02-04 01:11 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (739.30 KB, application/zip)
2017-02-04 02:18 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (834.64 KB, application/zip)
2017-02-04 02:21 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.48 MB, application/zip)
2017-02-04 03:17 PST, Build Bot 		no flags Details
Patch (146.53 KB, patch)
2017-02-04 14:15 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Update types (46.58 KB, patch)
2017-02-06 11:33 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Update types (67.64 KB, patch)
2017-02-06 12:14 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-02-04 01:03:37 PST 
Migrate ComplexTextController to use platform-independent types
Comment 1 Myles C. Maxfield 2017-02-04 01:11:43 PST 
Created attachment 300607 [details]
Patch
Comment 2 Build Bot 2017-02-04 02:18:15 PST 
Comment on attachment 300607 [details]
Patch

Attachment 300607 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3002808

New failing tests:
fast/text/complex-text-opacity.html
Comment 3 Build Bot 2017-02-04 02:18:18 PST 
Created attachment 300618 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-02-04 02:21:37 PST 
Comment on attachment 300607 [details]
Patch

Attachment 300607 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3002813

New failing tests:
fast/text/complex-text-opacity.html
Comment 5 Build Bot 2017-02-04 02:21:40 PST 
Created attachment 300619 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-02-04 03:17:39 PST 
Comment on attachment 300607 [details]
Patch

Attachment 300607 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3002881

New failing tests:
fast/text/complex-text-opacity.html
Comment 7 Build Bot 2017-02-04 03:17:43 PST 
Created attachment 300620 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Myles C. Maxfield 2017-02-04 14:15:29 PST 
Created attachment 300639 [details]
Patch
Comment 9 Myles C. Maxfield 2017-02-06 11:33:21 PST 
Created attachment 300740 [details]
Update types
Comment 10 Myles C. Maxfield 2017-02-06 12:14:16 PST 
Created attachment 300749 [details]
Update types
Comment 11 Brent Fulgham 2017-02-06 17:30:52 PST 
Comment on attachment 300749 [details]
Update types

View in context: https://bugs.webkit.org/attachment.cgi?id=300749&action=review

Looks good to me! r=me.

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:178
> +    float x = h;

Isn't CGFloat a double in 64-bit builds?

> Source/WebCore/platform/graphics/mac/ComplexTextController.h:25
> +#pragma once

Yay!
Comment 12 Myles C. Maxfield 2017-02-06 17:50:30 PST 
Comment on attachment 300749 [details]
Update types

View in context: https://bugs.webkit.org/attachment.cgi?id=300749&action=review

>> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:178
>> +    float x = h;
> 
> Isn't CGFloat a double in 64-bit builds?

Yep.
Comment 13 WebKit Commit Bot 2017-02-06 18:16:23 PST 
Comment on attachment 300749 [details]
Update types

Clearing flags on attachment: 300749

Committed r211765: <http://trac.webkit.org/changeset/211765>
Comment 14 WebKit Commit Bot 2017-02-06 18:16:29 PST 
All reviewed patches have been landed.  Closing bug.