| Summary: | [GTK] Web Inspector: Add new GTK+ icons for garbage collect and clean buttons in Console | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | Web Inspector | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | agomez, aperez, bugs-noreply, cgarcia, commit-queue, Hironori.Fujii, inspector-bugzilla-changes, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 311109 [details]
Patch
Created attachment 311110 [details]
screenshot of before and after this fix
Comment on attachment 311109 [details]
Patch
Weird, our old icons were 15x15? I've never heard of such an icon size before....
Comment on attachment 311109 [details] Patch Clearing flags on attachment: 311109 Committed r217386: <http://trac.webkit.org/changeset/217386> All reviewed patches have been landed. Closing bug. Thank you for the review. (In reply to Michael Catanzaro from comment #3) > Weird, our old icons were 15x15? I've never heard of such an icon size > before.... Right. it has been 16x16. NavigationItemClear.svg has three 1-unit-width vertical lines in the image. But, this lines were not aligned with dot grid. It were rendered blued 2-px-width lines if the image is rendered 16px dimension. This is why Joseph resized it to 15px dimension. Then, I shifted 0.5 unit left in this change. |
Add new GTK+ icons for garbage collect and clean buttons in Console Images: UserInterface/Images/NavigationItemClear.svg UserInterface/Images/NavigationItemGarbageCollect.svg Notes: - These icons are used in the Console's Navigator bar. - Current "Clear" was copied from "Trash" but should be designed for 16x16. (It currently is, but is used at 15x15 because it looks better and seems intended that way). - See bug 167345