Bug 166898

Summary: REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nested DOM element causes navigation bar buttons to be pushed off the leading edge
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[SCREENSHOT] the bug
none
Patch
timothy: review+
Patch
none
Patch none

Blaze Burg
Reported 2017-01-10 11:19:12 PST
Created attachment 298488 [details] [SCREENSHOT] the bug These should never be hidden by the [E] path components, but it seems they lose out while we could have made an Element path component description much shorter.
Attachments
[SCREENSHOT] the bug (291.44 KB, image/png)
2017-01-10 11:19 PST, Blaze Burg 		no flags
Details
Patch (1.84 KB, patch)
2017-01-12 16:40 PST, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2017-01-12 16:48 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2017-01-12 16:50 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-10 11:20:08 PST
<rdar://problem/29951737>
Nikita Vasilyev
Comment 2 2017-01-12 14:58:14 PST
This was broken a month ago by Bug 165745: Web Inspector: Cleanup HierarchicalPathComponent. https://trac.webkit.org/changeset/209711/trunk
Nikita Vasilyev
Comment 3 2017-01-12 16:40:05 PST
Created attachment 298734 [details] Patch
Timothy Hatcher
Comment 4 2017-01-12 16:42:34 PST
Comment on attachment 298734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298734&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); Perhaps doing !!this._selectorArrows would be better?
Nikita Vasilyev
Comment 5 2017-01-12 16:48:26 PST
Created attachment 298736 [details] Patch
Nikita Vasilyev
Comment 6 2017-01-12 16:49:11 PST
(In reply to comment #4) > Comment on attachment 298734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298734&action=review > > > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); > > Perhaps doing !!this._selectorArrows would be better? Indeed!
Nikita Vasilyev
Comment 7 2017-01-12 16:50:03 PST
Created attachment 298737 [details] Patch
WebKit Commit Bot
Comment 8 2017-01-12 17:31:07 PST
Comment on attachment 298737 [details] Patch Clearing flags on attachment: 298737 Committed r210691: <http://trac.webkit.org/changeset/210691>
WebKit Commit Bot
Comment 9 2017-01-12 17:31:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.