| Summary: | REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nested DOM element causes navigation bar buttons to be pushed off the leading edge | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||||||||
| Priority: | P1 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
This was broken a month ago by Bug 165745: Web Inspector: Cleanup HierarchicalPathComponent. https://trac.webkit.org/changeset/209711/trunk Created attachment 298734 [details]
Patch
Comment on attachment 298734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298734&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); Perhaps doing !!this._selectorArrows would be better? Created attachment 298736 [details]
Patch
(In reply to comment #4) > Comment on attachment 298734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298734&action=review > > > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); > > Perhaps doing !!this._selectorArrows would be better? Indeed! Created attachment 298737 [details]
Patch
Comment on attachment 298737 [details] Patch Clearing flags on attachment: 298737 Committed r210691: <http://trac.webkit.org/changeset/210691> All reviewed patches have been landed. Closing bug. |
Created attachment 298488 [details] [SCREENSHOT] the bug These should never be hidden by the [E] path components, but it seems they lose out while we could have made an Element path component description much shorter.