Summary: | [WK2] Add diagnostic logging to measure WebGL usage | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
Component: | Canvas | Assignee: | Chris Dumez <cdumez> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, andersca, barraclough, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, jonlee, kling, koivisto, kondapallykalyan, mjs, sam, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 166866 | ||||||||||||||
Attachments: |
|
Description
Chris Dumez
2017-01-05 09:08:56 PST
Created attachment 298367 [details]
Patch
Attachment 298367 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298390 [details]
Patch
Attachment 298390 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298402 [details]
Patch
Attachment 298402 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298407 [details]
Patch
Attachment 298407 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
ping review? Comment on attachment 298407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298407&action=review > Source/WebCore/platform/WebGLStateTracker.cpp:42 > + return m_WebGLContextCounter.count(); W should probably be lowercase. Created attachment 298808 [details]
Patch
Attachment 298808 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 298808 [details] Patch Clearing flags on attachment: 298808 Committed r210753: <http://trac.webkit.org/changeset/210753> All reviewed patches have been landed. Closing bug. |