Bug 166447

Summary: WebAssembly: Make spec-tests/f32.wast.js and spec-tests/f64.wast.js pass
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 166446    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Keith Miller
Reported 2016-12-22 16:43:35 PST
...
Attachments
Patch (6.62 KB, patch)
2016-12-22 18:08 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (10.91 KB, patch)
2016-12-22 18:11 PST, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-22 18:08:04 PST
Created attachment 297696 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-12-22 18:09:23 PST
<rdar://problem/29795709>
Radar WebKit Bug Importer
Comment 3 2016-12-22 18:09:23 PST
<rdar://problem/29795708>
WebKit Commit Bot
Comment 4 2016-12-22 18:10:03 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 5 2016-12-22 18:11:19 PST
Created attachment 297697 [details] Patch
Saam Barati
Comment 6 2016-12-22 18:14:18 PST
Comment on attachment 297696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297696&action=review > Source/JavaScriptCore/ChangeLog:12 > + we use an and and the sign bit gets dropped. I think you should finish this as: "sign bit gets dropped if one is 0.0 and the other is -0.0, otherwise, we get the same number back" or something like that
Keith Miller
Comment 7 2016-12-22 18:15:18 PST
Committed r210127: <http://trac.webkit.org/changeset/210127>
Note You need to log in before you can comment on or make changes to this bug.