Bug 166446

Summary: Add BitOr for floating points to B3
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166447    
Attachments:
Description Flags
Patch saam: review+

Keith Miller
Reported 2016-12-22 16:43:17 PST
Add BitOr for floating points to B3
Attachments
Patch (24.33 KB, patch)
2016-12-22 16:49 PST, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-22 16:49:32 PST
Created attachment 297689 [details] Patch
Michael Saboff
Comment 2 2016-12-22 16:52:03 PST
Comment on attachment 297689 [details] Patch The macro assembler changes look good to me.
Saam Barati
Comment 3 2016-12-22 16:55:26 PST
Comment on attachment 297689 [details] Patch r=me
Saam Barati
Comment 4 2016-12-22 16:57:26 PST
You might want to add the necessary code to B3ReduceDoubleToFloat. I think it's a one line change.
Saam Barati
Comment 5 2016-12-22 16:59:18 PST
(In reply to comment #4) > You might want to add the necessary code to B3ReduceDoubleToFloat. I think > it's a one line change. Ignore me. This comment is wrong.
Keith Miller
Comment 6 2016-12-22 17:20:40 PST
Committed r210124: <http://trac.webkit.org/changeset/210124>
Radar WebKit Bug Importer
Comment 7 2016-12-22 18:02:58 PST
<rdar://problem/29795645>
Note You need to log in before you can comment on or make changes to this bug.