Bug 166033

Summary: REGRESSION: API test failure: _WKDownload.OriginatingWebView
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=166032
https://bugs.webkit.org/show_bug.cgi?id=166031
Attachments:
Description Flags
proposed fix none

Ryan Haddad
Reported 2016-12-19 13:32:18 PST
FAIL _WKDownload.OriginatingWebView /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:250 Value of: !([download originatingWebView]) Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Attachments
proposed fix (1.62 KB, patch)
2016-12-21 15:31 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-12-19 13:32:56 PST
Started after the Sierra bots were updated to 10.12.2
Radar WebKit Bug Importer
Comment 2 2016-12-20 12:35:57 PST
<rdar://problem/29758428>
Alexey Proskuryakov
Comment 3 2016-12-21 15:31:16 PST
Created attachment 297627 [details] proposed fix Similar to Simon's fix in bug 166031. This fix seems a little weaker, since this test is async, and we can't drain all objects autoreleased by AppKit. It does fix the test though.
WebKit Commit Bot
Comment 4 2016-12-21 15:59:29 PST
Comment on attachment 297627 [details] proposed fix Clearing flags on attachment: 297627 Committed r210082: <http://trac.webkit.org/changeset/210082>
WebKit Commit Bot
Comment 5 2016-12-21 15:59:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.