Bug 166032

Summary: REGRESSION: API test failure: WKWebView.LocalStorageClear
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=166031
https://bugs.webkit.org/show_bug.cgi?id=166033
Attachments:
Description Flags
proposed fix none

Ryan Haddad
Reported 2016-12-19 13:32:16 PST
FAIL WKWebView.LocalStorageClear /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:84 Value of: [[NSFileManager defaultManager] fileExistsAtPath:dbWALPath] Actual: true Expected: false /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:85 Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerPath] Actual: true Expected: false /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:86 Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerSHMPath] Actual: true Expected: false /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:87 Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerWALPath] Actual: true Expected: false https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Attachments
proposed fix (2.49 KB, patch)
2016-12-21 15:23 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-12-19 13:32:53 PST
Started after the Sierra bots were updated to 10.12.2
Radar WebKit Bug Importer
Comment 2 2016-12-20 12:35:26 PST
<rdar://problem/29758423>
Brady Eidson
Comment 3 2016-12-20 12:39:08 PST
Confirmed locally on my 10.12.2 machine (where API tests all passed back on 10.12.1)
Alexey Proskuryakov
Comment 4 2016-12-21 15:23:50 PST
Created attachment 297626 [details] proposed fix Same as Simon's fix in bug 166031.
WebKit Commit Bot
Comment 5 2016-12-21 17:58:07 PST
Comment on attachment 297626 [details] proposed fix Clearing flags on attachment: 297626 Committed r210093: <http://trac.webkit.org/changeset/210093>
WebKit Commit Bot
Comment 6 2016-12-21 17:58:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.