Bug 165823

Summary: Move existing CDM* implementations into modules/encryptedmedia/legacy
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 165850    
Attachments:
Description Flags
Patch for landing sam: review+

Jer Noble
Reported 2016-12-13 15:07:27 PST
Move existing CDM* implementations into modules/encryptedmedia/legacy
Attachments
Patch for landing (44.56 KB, patch)
2016-12-13 15:12 PST, Jer Noble 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-12-13 15:12:04 PST
Created attachment 297044 [details] Patch for landing
WebKit Commit Bot
Comment 2 2016-12-13 15:14:59 PST
Attachment 297044 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/LegacyCDMSession.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/MediaPlayer.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 9 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2016-12-14 13:57:26 PST
Comment on attachment 297044 [details] Patch for landing rs=me
Jer Noble
Comment 4 2016-12-16 13:53:25 PST
Committed r209936: <http://trac.webkit.org/changeset/209936>
Note You need to log in before you can comment on or make changes to this bug.