Bug 165750

Summary: [css-grid] Add some test cases that were removed in r209562
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hyatt, jfernandez, svillar, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2016-12-12 01:39:48 PST
[css-grid] Add some test cases that were removed in r209562
Attachments
Patch (6.78 KB, patch)
2016-12-12 01:40 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (10.19 KB, patch)
2016-12-12 01:47 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-12-12 01:40:15 PST
Created attachment 296899 [details] Patch
Manuel Rego Casasnovas
Comment 2 2016-12-12 01:47:40 PST
Created attachment 296900 [details] Patch
Manuel Rego Casasnovas
Comment 3 2016-12-12 01:49:30 PST
These tests cases were removed in bug #165623.
Sergio Villar Senin
Comment 4 2016-12-12 06:40:16 PST
Comment on attachment 296900 [details] Patch I guess you have verified that 0fr does not trigger a division by zero or any other error like that in the renderer.
Manuel Rego Casasnovas
Comment 5 2016-12-12 12:24:32 PST
(In reply to comment #4) > Comment on attachment 296900 [details] > Patch > > I guess you have verified that 0fr does not trigger a division by zero or > any other error like that in the renderer. Yes the patch related to that is quite old r190308 (see bug #148944), but it seems the changes on the parser were not done at that time. In any case this is just modifying the tests.
WebKit Commit Bot
Comment 6 2016-12-12 12:49:44 PST
Comment on attachment 296900 [details] Patch Clearing flags on attachment: 296900 Committed r209721: <http://trac.webkit.org/changeset/209721>
WebKit Commit Bot
Comment 7 2016-12-12 12:49:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.