Bug 165641

Summary:

[WebIDL] Merge JSDictionary into Dictionary, and remove unused bits

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, darin, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

165625

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Patch	mitz: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none

Sam Weinig

Reported 2016-12-08 18:10:49 PST

[WebIDL] Merge JSDictionary into Dictionary, and remove unused bits

Attachments
Patch (54.57 KB, patch) 2016-12-08 18:18 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.13 MB, application/zip) 2016-12-08 19:02 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (1.79 MB, application/zip) 2016-12-08 19:26 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.57 MB, application/zip) 2016-12-08 20:21 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted) 2016-12-08 20:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted) 2016-12-08 22:42 PST, Build Bot	no flags	Details
Patch (47.49 KB, patch) 2016-12-09 22:27 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (47.49 KB, patch) 2016-12-10 11:38 PST, Sam Weinig	mitz: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.27 MB, application/zip) 2016-12-10 13:13 PST, Build Bot	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2016-12-08 18:18:06 PST

Created attachment 296608 [details] Patch

Build Bot

Comment 2 2016-12-08 19:02:47 PST

Comment on attachment 296608 [details] Patch Attachment 296608 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2658822 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-12-08 19:02:50 PST

Created attachment 296613 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-12-08 19:26:25 PST

Comment on attachment 296608 [details] Patch Attachment 296608 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2659185 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-12-08 19:26:27 PST

Created attachment 296620 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-12-08 20:21:46 PST

Comment on attachment 296608 [details] Patch Attachment 296608 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2660219 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-12-08 20:21:48 PST

Created attachment 296629 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-12-08 20:42:26 PST

Comment on attachment 296608 [details] Patch Attachment 296608 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2659838 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2016-12-08 20:42:32 PST

Created attachment 296633 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2016-12-08 22:42:12 PST

Comment on attachment 296608 [details] Patch Attachment 296608 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2661932 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2016-12-08 22:42:18 PST

Created attachment 296642 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Darin Adler

Comment 12 2016-12-09 21:27:29 PST

*** Bug 156853 has been marked as a duplicate of this bug. ***

Sam Weinig

Comment 13 2016-12-09 22:27:38 PST

Created attachment 296780 [details] Patch

Sam Weinig

Comment 14 2016-12-10 11:38:52 PST

Created attachment 296812 [details] Patch

mitz

Comment 15 2016-12-10 13:05:19 PST

Comment on attachment 296812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296812&action=review > Source/WebCore/bindings/js/Dictionary.cpp:47 > +Dictionary::Dictionary(JSC::ExecState* state, JSC::JSValue value) No need for JSC:: here. > Source/WebCore/bindings/js/Dictionary.cpp:85 > +// MARK: - > +// MARK: Value convversions Extra “v” in “convversions”. Can collapse these into // MARK: - Value conversions

Build Bot

Comment 16 2016-12-10 13:13:46 PST

Comment on attachment 296812 [details] Patch Attachment 296812 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2690730 New failing tests: transitions/default-timing-function.html

Build Bot

Comment 17 2016-12-10 13:13:48 PST

Created attachment 296818 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Sam Weinig

Comment 18 2016-12-10 14:14:28 PST

Committed r209674: <http://trac.webkit.org/changeset/209674>

Note You need to log in before you can comment on or make changes to this bug.