Bug 165625

Summary: [WebIDL] Remove custom bindings for Geolocation
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, ossy, pvollan, rniwa, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 165641    
Attachments:
Description Flags
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-yosemite-wk2 none

Sam Weinig
Reported 2016-12-08 13:33:36 PST
[WebIDL] Remove custom bindings for Geolcation
Attachments
Patch (56.44 KB, patch)
2016-12-08 13:43 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (57.23 KB, patch)
2016-12-10 08:07 PST, Sam Weinig 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.49 MB, application/zip)
2016-12-10 10:32 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-12-08 13:43:12 PST
Created attachment 296561 [details] Patch
Sam Weinig
Comment 2 2016-12-08 14:53:06 PST
Committed r209574: <http://trac.webkit.org/changeset/209574>
Csaba Osztrogonác
Comment 3 2016-12-09 04:17:42 PST
(In reply to comment #2) > Committed r209574: <http://trac.webkit.org/changeset/209574> It broke the WinCairo build, see build.webkit.org for details.
Ryan Haddad
Comment 4 2016-12-09 10:13:03 PST
Reverted r209574 for reason: This change broke the Windows build. Committed r209612: <http://trac.webkit.org/changeset/209612>
Ryan Haddad
Comment 5 2016-12-09 10:13:24 PST
(In reply to comment #4) > Reverted r209574 for reason: > > This change broke the Windows build. > > Committed r209612: <http://trac.webkit.org/changeset/209612> Link to failure: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/82527
Sam Weinig
Comment 6 2016-12-09 10:46:17 PST
Any windows folks understand the issue?
Alex Christensen
Comment 7 2016-12-09 15:19:56 PST
I confirmed inlining Geolocation::frame in the header fixes the linker issue. Not sure exactly why, but I don't see any reason to look into this further. I will look into it further if we run into more such problems. Remember to remove WEBCORE_EXPORT, include Document.h, and remove the definition in the .cpp
Sam Weinig
Comment 8 2016-12-10 08:07:51 PST
Created attachment 296802 [details] Patch
Build Bot
Comment 9 2016-12-10 10:32:04 PST
Comment on attachment 296802 [details] Patch Attachment 296802 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2689733 New failing tests: inspector/codemirror/prettyprinting-css-rules.html
Build Bot
Comment 10 2016-12-10 10:32:07 PST
Created attachment 296807 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Sam Weinig
Comment 11 2016-12-10 11:36:38 PST
Committed r209669: <http://trac.webkit.org/changeset/209669>
Note You need to log in before you can comment on or make changes to this bug.