Bug 165510

Summary: WebAssembly: Make more demos run
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: Saam Barati <sbarati>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, jfbastien, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165118    
Bug Blocks: 161709    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
patch
keith_miller: review+
patch for landing
none
patch for landing
sbarati: commit-queue-
patch for landing none

Description JF Bastien 2016-12-06 20:24:27 PST
WebAssemblyModuleRecord::link has a FIXME to implement it.
Comment 1 Radar WebKit Bug Importer 2016-12-20 14:28:51 PST
<rdar://problem/29760310>
Comment 2 Yusuke Suzuki 2017-03-07 00:36:13 PST
Seems like this error is raised now in http://webassembly.org/demo/.
Comment 3 Saam Barati 2017-03-09 13:36:06 PST
Created attachment 303980 [details]
WIP

need to add some tests.
Comment 4 Saam Barati 2017-03-09 17:18:13 PST
This demo now runs for me:
https://kripken.github.io/BananaBread/cube2/bb.html
Comment 5 Saam Barati 2017-03-09 17:21:23 PST
Created attachment 304013 [details]
WIP
Comment 6 Saam Barati 2017-03-09 18:05:43 PST
Created attachment 304017 [details]
WIP

I think it's done. Just need some tests now for the wrapper function I added.
Comment 7 Saam Barati 2017-03-09 19:39:06 PST
Created attachment 304023 [details]
patch
Comment 8 WebKit Commit Bot 2017-03-09 19:42:02 PST
Attachment 304023 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Keith Miller 2017-03-10 11:49:45 PST
Comment on attachment 304023 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304023&action=review

r=me.

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:1064
> +    RELEASE_ASSERT(toSave.numberOfSetGPRs() == toSaveSize);

I'm not sure this needs to be a release assert.
Comment 10 Saam Barati 2017-03-10 14:02:41 PST
Created attachment 304072 [details]
patch for landing
Comment 11 Saam Barati 2017-03-10 14:06:53 PST
Created attachment 304073 [details]
patch for landing
Comment 12 WebKit Commit Bot 2017-03-10 16:09:20 PST
Attachment 304073 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Saam Barati 2017-03-10 16:18:33 PST
Created attachment 304091 [details]
patch for landing
Comment 14 WebKit Commit Bot 2017-03-10 16:20:27 PST
Attachment 304091 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 WebKit Commit Bot 2017-03-10 18:04:40 PST
Comment on attachment 304091 [details]
patch for landing

Clearing flags on attachment: 304091

Committed r213745: <http://trac.webkit.org/changeset/213745>
Comment 16 WebKit Commit Bot 2017-03-10 18:04:45 PST
All reviewed patches have been landed.  Closing bug.