Bug 165196

Summary: Some scroll snapping tests are still flaky
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, jlewis3, luiz, simon.fraser, tonikitoo, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148408
https://bugs.webkit.org/show_bug.cgi?id=148407
https://bugs.webkit.org/show_bug.cgi?id=167561
https://bugs.webkit.org/show_bug.cgi?id=167661
https://bugs.webkit.org/show_bug.cgi?id=167321
https://bugs.webkit.org/show_bug.cgi?id=172148
Attachments:
Description Flags
Patch
none
Another attempt to observe flaky failures.
none
Patch
wenson_hsieh: review+
Patch none

Description Wenson Hsieh 2016-11-30 08:02:41 PST
So far, this includes three tests:
- tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html
- tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html
- tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html
Comment 1 Wenson Hsieh 2016-11-30 10:13:03 PST
Created attachment 295729 [details]
Patch
Comment 2 Wenson Hsieh 2016-11-30 16:49:42 PST
Created attachment 295789 [details]
Another attempt to observe flaky failures.
Comment 3 Wenson Hsieh 2017-07-24 09:44:01 PDT
*** Bug 172148 has been marked as a duplicate of this bug. ***
Comment 4 Simon Fraser (smfr) 2020-03-19 18:46:19 PDT
scroll-snap-mandatory-mainframe-slow-vertical.html is still flakey.

The scroll snap timer fires on the scrolling thread with the right offset, but the main thread hasn't caught up yet by the time we remove the "scroll snap" reason on the wheel event monitor.
Comment 5 Simon Fraser (smfr) 2020-03-19 21:22:00 PDT
Created attachment 394064 [details]
Patch
Comment 6 Wenson Hsieh 2020-03-19 21:29:05 PDT
Comment on attachment 394064 [details]
Patch

r=me with the UNUSED_PARAM to fix the iOS build.
Comment 7 Simon Fraser (smfr) 2020-03-19 21:36:42 PDT
Created attachment 394066 [details]
Patch
Comment 8 EWS 2020-03-19 23:03:39 PDT
Committed r258753: <https://trac.webkit.org/changeset/258753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394066 [details].
Comment 9 Radar WebKit Bug Importer 2020-03-19 23:04:18 PDT
<rdar://problem/60671382>
Comment 10 Simon Fraser (smfr) 2020-03-20 09:23:58 PDT
*** Bug 209293 has been marked as a duplicate of this bug. ***