Bug 165175

Summary: [Modern Media Controls] Only show controls when the controls attribute is set
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, hi, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2016-11-29 16:43:54 PST
[Modern Media Controls] Only show controls when the controls attribute is set
Attachments
Patch (41.36 KB, patch)
2016-11-29 16:46 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-11-29 16:46:18 PST
Created attachment 295671 [details] Patch
Dean Jackson
Comment 2 2016-11-29 17:57:01 PST
Comment on attachment 295671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295671&action=review > Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:-50 > - layoutDelegate: this Was this line important?
Antoine Quint
Comment 3 2016-11-29 18:00:03 PST
(In reply to comment #2) > Comment on attachment 295671 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295671&action=review > > > Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:-50 > > - layoutDelegate: this > > Was this line important? It wasn't.
WebKit Commit Bot
Comment 4 2016-11-29 18:26:24 PST
Comment on attachment 295671 [details] Patch Clearing flags on attachment: 295671 Committed r209108: <http://trac.webkit.org/changeset/209108>
WebKit Commit Bot
Comment 5 2016-11-29 18:26:27 PST
All reviewed patches have been landed. Closing bug.
Antoine Quint
Comment 6 2016-12-01 13:49:13 PST
*** Bug 165010 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 7 2016-12-01 13:49:31 PST
<rdar://problem/29466351>
Note You need to log in before you can comment on or make changes to this bug.