Bug 165175 - [Modern Media Controls] Only show controls when the controls attribute is set
Summary: [Modern Media Controls] Only show controls when the controls attribute is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
: 165010 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-29 16:43 PST by Antoine Quint
Modified: 2016-12-01 13:49 PST (History)
4 users (show)

See Also:


Attachments
Patch (41.36 KB, patch)
2016-11-29 16:46 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-29 16:43:54 PST
[Modern Media Controls] Only show controls when the controls attribute is set
Comment 1 Antoine Quint 2016-11-29 16:46:18 PST
Created attachment 295671 [details]
Patch
Comment 2 Dean Jackson 2016-11-29 17:57:01 PST
Comment on attachment 295671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295671&action=review

> Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:-50
> -            layoutDelegate: this

Was this line important?
Comment 3 Antoine Quint 2016-11-29 18:00:03 PST
(In reply to comment #2)
> Comment on attachment 295671 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295671&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:-50
> > -            layoutDelegate: this
> 
> Was this line important?

It wasn't.
Comment 4 WebKit Commit Bot 2016-11-29 18:26:24 PST
Comment on attachment 295671 [details]
Patch

Clearing flags on attachment: 295671

Committed r209108: <http://trac.webkit.org/changeset/209108>
Comment 5 WebKit Commit Bot 2016-11-29 18:26:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Antoine Quint 2016-12-01 13:49:13 PST
*** Bug 165010 has been marked as a duplicate of this bug. ***
Comment 7 Radar WebKit Bug Importer 2016-12-01 13:49:31 PST
<rdar://problem/29466351>