Bug 165126

Summary: Generated sandbox profile is not being put in the correct Resources directory
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, ap, bfulgham, bshafiei, commit-queue, jimoase
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2016-11-28 17:21:11 PST
In Bug 164625 I changed "com.apple.WebKit.plugin-common.sb" to be a generated file so we could deploy new sandbox features as they became available in newer OS releases without breaking builds targeting older systems. There were two changes: Committed r208589: <http://trac.webkit.org/changeset/208589> Committed r208835: <https://trac.webkit.org/changeset/208835> Unfortunately, there is still an error. The generated file is being copied to the "Resources" folder, not the correct "Resources/PlugInSandboxProfiles".
Attachments
Patch (1.85 KB, patch)
2016-11-28 17:29 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-11-28 17:21:27 PST
<rdar://problem/29409758>
Brent Fulgham
Comment 2 2016-11-28 17:29:09 PST
Created attachment 295557 [details] Patch
WebKit Commit Bot
Comment 3 2016-11-28 18:29:59 PST
Comment on attachment 295557 [details] Patch Clearing flags on attachment: 295557 Committed r209057: <http://trac.webkit.org/changeset/209057>
WebKit Commit Bot
Comment 4 2016-11-28 18:30:03 PST
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2016-11-29 13:19:31 PST
*** Bug 165038 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.