Bug 164625 - Remove unused FontService from sandbox
Summary: Remove unused FontService from sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-10 17:17 PST by Brent Fulgham
Modified: 2016-11-28 17:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2016-11-10 17:20 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (47.97 KB, patch)
2016-11-10 18:40 PST, Brent Fulgham 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-10 17:17:23 PST 
In macOS Sierra (and newer) we no longer need access to com.apple.FontServer. So, remove it from the sandbox.
Comment 1 Brent Fulgham 2016-11-10 17:18:33 PST 
<rdar://problem/26899976>
Comment 2 Brent Fulgham 2016-11-10 17:20:45 PST 
Created attachment 294447 [details]
Patch
Comment 3 Brent Fulgham 2016-11-10 18:40:23 PST 
Created attachment 294457 [details]
Patch
Comment 4 Brent Fulgham 2016-11-10 18:41:00 PST 
Revised patch to generate from an 'in' file so we can exclude content more easily based on OS level. This will be useful in some future patches.
Comment 5 Alex Christensen 2016-11-11 09:10:43 PST 
Comment on attachment 294457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294457&action=review

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81
> +;; OS X 10.7 (Lion) compatibility

Really?

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248
> +(if (equal? os-version "10.7")

Do we still need this?

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355
> +(if (equal? os-version "10.7")

...
Comment 6 Brent Fulgham 2016-11-11 09:20:42 PST 
(In reply to comment #5)
> Comment on attachment 294457 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294457&action=review
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81
> > +;; OS X 10.7 (Lion) compatibility
> 
> Really?
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248
> > +(if (equal? os-version "10.7")
> 
> Do we still need this?
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355
> > +(if (equal? os-version "10.7")
> 
> ...

Not to fear! More changes coming soon. This is just a move of the existing file to a new location -- I didn't want to clean it up yet.
Comment 7 Brent Fulgham 2016-11-11 09:21:58 PST 
Committed r208589: <http://trac.webkit.org/changeset/208589>
Comment 8 Brent Fulgham 2016-11-28 17:17:28 PST 
A follow-up fix was landed here:

Committed r208835: <https://trac.webkit.org/changeset/208835>