Bug 165126 - Generated sandbox profile is not being put in the correct Resources directory
Summary: Generated sandbox profile is not being put in the correct Resources directory
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
: 165038 (view as bug list)
Depends on:
Reported: 2016-11-28 17:21 PST by Brent Fulgham
Modified: 2016-11-29 13:19 PST (History)
7 users (show)

See Also:

Patch (1.85 KB, patch)
2016-11-28 17:29 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-28 17:21:11 PST
In Bug 164625 I changed "com.apple.WebKit.plugin-common.sb" to be a generated file so we could deploy new sandbox features as they became available in newer OS releases without breaking builds targeting older systems.

There were two changes:

    Committed r208589: <http://trac.webkit.org/changeset/208589>
    Committed r208835: <https://trac.webkit.org/changeset/208835>

Unfortunately, there is still an error. The generated file is being copied to the "Resources" folder, not the correct "Resources/PlugInSandboxProfiles".
Comment 1 Brent Fulgham 2016-11-28 17:21:27 PST
Comment 2 Brent Fulgham 2016-11-28 17:29:09 PST
Created attachment 295557 [details]
Comment 3 WebKit Commit Bot 2016-11-28 18:29:59 PST
Comment on attachment 295557 [details]

Clearing flags on attachment: 295557

Committed r209057: <http://trac.webkit.org/changeset/209057>
Comment 4 WebKit Commit Bot 2016-11-28 18:30:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2016-11-29 13:19:31 PST
*** Bug 165038 has been marked as a duplicate of this bug. ***