Summary: | Fix exception scope verification failures in runtime/Operations.cpp/h. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 162351, 165035 | ||||||
Attachments: |
|
Description
Mark Lam
2016-11-23 09:24:04 PST
Created attachment 295370 [details]
proposed patch.
Comment on attachment 295370 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295370&action=review > Source/JavaScriptCore/runtime/Operations.cpp:54 > + auto p2String = p2.toString(callFrame); I think it's helpful to have types here. > Source/JavaScriptCore/runtime/Operations.cpp:61 > + auto p1String = p1.toString(callFrame); ditto Comment on attachment 295370 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295370&action=review >> Source/JavaScriptCore/runtime/Operations.cpp:54 >> + auto p2String = p2.toString(callFrame); > > I think it's helpful to have types here. Fixed. >> Source/JavaScriptCore/runtime/Operations.cpp:61 >> + auto p1String = p1.toString(callFrame); > > ditto Fixed. Thanks for the review. Landed in r209030: <http://trac.webkit.org/r209030>. |