Bug 165035

Summary: Fix exception scope verification failures in JSObject* files.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: buildbot, fpizlo, ggaren, jfbastien, keith_miller, msaboff, rniwa, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 164972, 165046    
Bug Blocks: 162351    
Attachments:
Description Flags
proposed patch.
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews117 for mac-yosemite
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
proposed patch.
saam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite none

Mark Lam
Reported 2016-11-22 13:24:15 PST
Patch coming.
Attachments
proposed patch. (20.01 KB, patch)
2016-11-22 13:29 PST, Mark Lam 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (1.28 MB, application/zip)
2016-11-22 14:51 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.56 MB, application/zip)
2016-11-22 14:55 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-yosemite (2.13 MB, application/zip)
2016-11-22 14:59 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.13 MB, application/zip)
2016-11-22 15:04 PST, Build Bot 		no flags
Details
proposed patch. (20.02 KB, patch)
2016-11-28 16:01 PST, Mark Lam 		saam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (1.26 MB, application/zip)
2016-11-28 17:31 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.12 MB, application/zip)
2016-11-28 17:50 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite (1.51 MB, application/zip)
2016-11-28 19:24 PST, Build Bot 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-11-22 13:29:35 PST
Created attachment 295341 [details] proposed patch.
Build Bot
Comment 2 2016-11-22 14:51:27 PST
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2557722 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Build Bot
Comment 3 2016-11-22 14:51:32 PST
Created attachment 295343 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-11-22 14:55:21 PST
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2557726 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Build Bot
Comment 5 2016-11-22 14:55:25 PST
Created attachment 295344 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-11-22 14:59:35 PST
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2557729 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/array-proto-func-property-getter-except.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Build Bot
Comment 7 2016-11-22 14:59:38 PST
Created attachment 295345 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-11-22 15:04:45 PST
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2557736 New failing tests: js/dom/exception-sequencing-binops2.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html
Build Bot
Comment 9 2016-11-22 15:04:49 PST
Created attachment 295346 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Mark Lam
Comment 10 2016-11-22 15:08:05 PST
Comment on attachment 295341 [details] proposed patch. Taking out of review while I investigate failures
Mark Lam
Comment 11 2016-11-23 09:29:09 PST
The reason for the failures is because this patch relies on fixes from 2 other patches: 1. Fix exception scope verification failures in ArrayConstructor.cpp and ArrayPrototype.cpp https://bugs.webkit.org/show_bug.cgi?id=164972 2. Fix exception scope verification failures in runtime/Operations.cpp/h. https://bugs.webkit.org/show_bug.cgi?id=165046 Let's hold off on this patch until those others have landed.
Mark Lam
Comment 12 2016-11-28 16:01:41 PST
Created attachment 295546 [details] proposed patch. The relevant other patches have landed. Let's rebase and test this on the EWS again.
Build Bot
Comment 13 2016-11-28 17:31:09 PST
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2585630 New failing tests: http/tests/plugins/cross-frame-object-access.html
Build Bot
Comment 14 2016-11-28 17:31:13 PST
Created attachment 295558 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 15 2016-11-28 17:50:34 PST
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2585741 New failing tests: http/tests/plugins/cross-frame-object-access.html
Build Bot
Comment 16 2016-11-28 17:50:37 PST
Created attachment 295559 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 17 2016-11-28 19:24:49 PST
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2586144 New failing tests: http/tests/plugins/cross-frame-object-access.html
Build Bot
Comment 18 2016-11-28 19:24:54 PST
Created attachment 295571 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Mark Lam
Comment 19 2016-11-29 11:13:02 PST
(In reply to comment #17) > New failing tests: > http/tests/plugins/cross-frame-object-access.html The reason for this failure is that there's a missing exception check in NPJSObject.cpp. Fixing that missing exception check is easy. However, the test now fails because the plugin is now losing some XSS ability. I'm not sure if it is supposed to have that ability to begin with (though the test claims that it should). This will take a little more investigation.
Mark Lam
Comment 20 2017-09-09 20:51:14 PDT
This is now supplanted by https://bugs.webkit.org/show_bug.cgi?id=176662. Closing as a dupe. *** This bug has been marked as a duplicate of bug 176662 ***
Note You need to log in before you can comment on or make changes to this bug.