Summary: | Remove the deprecated WebKitSubtleCrypto interface | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
Component: | WebCore Misc. | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, bfulgham, buildbot, cdumez, jiewen_tan, sam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=160880 | ||||||||
Bug Depends on: | 164943, 164939, 169806 | ||||||||
Bug Blocks: | 173325 | ||||||||
Attachments: |
|
Description
Jiewen Tan
2016-11-18 11:31:21 PST
Jiewen, are you working on this? If not, I'll take it. (In reply to Sam Weinig from comment #2) > Jiewen, are you working on this? If not, I'll take it. No, I am not. Feel free to take it. (In reply to Jiewen Tan from comment #3) > (In reply to Sam Weinig from comment #2) > > Jiewen, are you working on this? If not, I'll take it. > > No, I am not. Feel free to take it. Great. Created attachment 318540 [details]
Patch
Attachment 318540 [details] did not pass style-queue:
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:795: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:796: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:797: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:798: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:799: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:800: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:801: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:802: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:803: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:804: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:805: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1008: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1009: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1010: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1011: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:260: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:261: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:262: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:263: Path does not exist. [test/expectations] [5]
Total errors found: 19 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318545 [details]
Patch
Comment on attachment 318545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318545&action=review Thank you Sam. Looks good. Please address the following comments. Just wondering if you are planning of improving the structure further after the removal of WebKitSubtle? > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53 > bool keyAlgorithmMatches(const CryptoKey&) const; Maybe we should remove this as well? Comment on attachment 318545 [details]
Patch
rs=me
(In reply to Jiewen Tan from comment #8) > Comment on attachment 318545 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318545&action=review > > Thank you Sam. Looks good. Please address the following comments. Just > wondering if you are planning of improving the structure further after the > removal of WebKitSubtle? Yeah, this was the first pass. There are a few simplifications I was going to make after this lands. > > > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53 > > bool keyAlgorithmMatches(const CryptoKey&) const; > > Maybe we should remove this as well? If its unused, yes. Committed r220941: <http://trac.webkit.org/changeset/220941> |