Bug 164776

Summary: [GStreamer][GL] build broken when using gst-plugins-bad from git
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, magomez, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164817    
Attachments:
Description Flags
patch calvaris: review+, calvaris: commit-queue-

Philippe Normand
Reported 2016-11-15 09:21:21 PST
../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: In static member function ‘static GstContext* WebCore::MediaPlayerPrivateGStreamerBase::requestGLContext(const gchar*, WebCore::MediaPlayerPrivateGStreamerBase*)’: ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:310:49: warning: ‘GType GST_GL_TYPE_CONTEXT()’ is deprecated: Use 'GST_TYPE_GL_CONTEXT' instead [-Wdeprecated-declarations] gst_structure_set(structure, "context", GST_GL_TYPE_CONTEXT, player->gstGLContext(), nullptr); ^~~~~~~~~~~~~~~~~~~ In file included from ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gl/gl.h:33:0, from ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:50: Will send a patch.
Attachments
patch (2.10 KB, patch)
2016-11-15 09:26 PST, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2016-11-15 09:26:27 PST
Created attachment 294843 [details] patch
Xabier Rodríguez Calvar
Comment 2 2016-11-16 03:39:44 PST
Comment on attachment 294843 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=294843&action=review > Source/WebCore/ChangeLog:10 > + GStreamer GL context GType was renamed, add an ifder taking this ifder.
Philippe Normand
Comment 3 2016-11-16 04:00:29 PST
Committed r208789: <http://trac.webkit.org/changeset/208789>
Note You need to log in before you can comment on or make changes to this bug.