Bug 164644

Summary: WorkerGlobalScope's indexedDB property should be on the prototype, not the instance
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, darin, ggaren, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 164713    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-11-11 11:05:43 PST
WorkerGlobalScope's indexedDB property should be on the prototype, not the instance. Causing failure on http://w3c-test.org/IndexedDB/interfaces.worker.html
Attachments
Patch (74.87 KB, patch)
2016-11-11 14:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.18 KB, patch)
2016-11-11 14:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-11-11 11:10:58 PST
This is because WorkerGlobalScope is not a [Global] object, DedicatedWorkerGlobalScope is. Therefore, WorkerGlobalScope should have its properties / operations on the prototype, except for the constructors (such as IDBDatabase).
Chris Dumez
Comment 2 2016-11-11 14:07:57 PST
Created attachment 294534 [details] Patch
Chris Dumez
Comment 3 2016-11-11 14:12:04 PST
Created attachment 294535 [details] Patch
Brady Eidson
Comment 4 2016-11-11 14:13:53 PST
Comment on attachment 294535 [details] Patch LGTM once all the little bot bubbles are green!
Chris Dumez
Comment 5 2016-11-11 14:56:33 PST
Comment on attachment 294535 [details] Patch Clearing flags on attachment: 294535 Committed r208613: <http://trac.webkit.org/changeset/208613>
Chris Dumez
Comment 6 2016-11-11 14:56:38 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2016-11-14 08:53:57 PST
(In reply to comment #5) > Comment on attachment 294535 [details] > Patch > > Clearing flags on attachment: 294535 > > Committed r208613: <http://trac.webkit.org/changeset/208613> It broke the !ENABLE(FETCH_API) build, I filed a bug report about this regression, see bug164713 for details.
Note You need to log in before you can comment on or make changes to this bug.