Bug 164638

Summary: Get rid of old sandbox rules for OS's we no longer support
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Severity: Normal CC: achristensen, aestes, ap, bfulgham, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch simon.fraser: review+

Description Brent Fulgham 2016-11-11 09:52:13 PST
The existing Sandbox profiles refer to various unsupported versions of macOS. These conditionals are evaluated at runtime, so have a non-zero cost, and are always false for anything shipped in the last few years.

Clean up these old entries!
Comment 1 Brent Fulgham 2016-11-11 10:51:57 PST
Created attachment 294507 [details]
Comment 2 Brent Fulgham 2016-11-11 14:19:46 PST
Committed r208611: <http://trac.webkit.org/changeset/208611>
Comment 3 Brent Fulgham 2016-11-29 19:51:30 PST
This change is wrong. I misread the Scheme conditional clause as if it was C++, instead I should have recognized that Scheme's conditional looks like this:

(if (predicate ...)
    (stuff to do if true)
    (stuff to do if false))

I will fix this in Bug 165187.