Bug 164494

Summary:

[Mac] Stop using deprecated AppKit enumeration values

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, mitz, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=164572

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Chris Dumez 2016-11-07 16:20:31 PST

Stop using deprecated AppKit enumeration values.

Comment 1 Chris Dumez 2016-11-07 16:31:30 PST

Created attachment 294099 [details]
Patch

Comment 2 WebKit Commit Bot 2016-11-07 16:32:58 PST

Attachment 294099 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Chris Dumez 2016-11-07 16:36:04 PST

Created attachment 294100 [details]
Patch

Comment 4 WebKit Commit Bot 2016-11-07 16:38:05 PST

Attachment 294100 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Chris Dumez 2016-11-07 17:02:30 PST

Created attachment 294102 [details]
Patch

Comment 6 WebKit Commit Bot 2016-11-07 17:10:10 PST

Attachment 294102 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Chris Dumez 2016-11-07 18:34:58 PST

Created attachment 294111 [details]
Patch

Comment 8 WebKit Commit Bot 2016-11-07 18:38:03 PST

Attachment 294111 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Chris Dumez 2016-11-07 18:38:38 PST

Created attachment 294112 [details]
Patch

Comment 10 WebKit Commit Bot 2016-11-07 18:40:59 PST

Attachment 294112 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Chris Dumez 2016-11-07 19:01:37 PST

Created attachment 294117 [details]
Patch

Comment 12 WebKit Commit Bot 2016-11-07 19:05:04 PST

Attachment 294117 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 Chris Dumez 2016-11-07 19:06:38 PST

Created attachment 294118 [details]
Patch

Comment 14 WebKit Commit Bot 2016-11-07 19:10:05 PST

Attachment 294118 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Chris Dumez 2016-11-07 19:11:47 PST

Created attachment 294119 [details]
Patch

Comment 16 WebKit Commit Bot 2016-11-07 19:13:13 PST

Attachment 294119 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 17 Chris Dumez 2016-11-07 19:22:42 PST

Created attachment 294121 [details]
Patch

Comment 18 WebKit Commit Bot 2016-11-07 19:25:30 PST

Attachment 294121 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 19 Chris Dumez 2016-11-07 19:26:07 PST

Created attachment 294123 [details]
Patch

Comment 20 WebKit Commit Bot 2016-11-07 19:27:20 PST

Attachment 294123 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 21 Chris Dumez 2016-11-07 19:39:52 PST

Created attachment 294125 [details]
Patch

Comment 22 WebKit Commit Bot 2016-11-07 19:41:35 PST

Attachment 294125 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 23 Chris Dumez 2016-11-07 20:12:25 PST

Created attachment 294128 [details]
Patch

Comment 24 WebKit Commit Bot 2016-11-07 20:14:41 PST

Attachment 294128 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 25 Chris Dumez 2016-11-07 21:06:59 PST

Created attachment 294130 [details]
Patch

Comment 26 WebKit Commit Bot 2016-11-07 21:08:56 PST

Attachment 294130 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 27 Chris Dumez 2016-11-07 21:30:32 PST

Created attachment 294132 [details]
Patch

Comment 28 WebKit Commit Bot 2016-11-07 21:33:08 PST

Attachment 294132 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 29 Chris Dumez 2016-11-07 21:43:02 PST

Created attachment 294133 [details]
Patch

Comment 30 WebKit Commit Bot 2016-11-07 21:46:15 PST

Attachment 294133 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 31 Darin Adler 2016-11-07 22:42:43 PST

Comment on attachment 294133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294133&action=review

> Source/WebCore/editing/cocoa/HTMLConverter.mm:70


I suggest doing this in WebCorePrefix.h the way we do in WebKit2Prefix.h instead of doing it each file where it is needed.

Comment 32 Chris Dumez 2016-11-08 09:21:28 PST

Created attachment 294164 [details]
Patch

Comment 33 WebKit Commit Bot 2016-11-08 09:23:04 PST

Attachment 294164 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 34 Chris Dumez 2016-11-08 09:56:11 PST

Created attachment 294167 [details]
Patch

Comment 35 WebKit Commit Bot 2016-11-08 09:58:10 PST

Attachment 294167 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 36 Chris Dumez 2016-11-09 10:18:53 PST

Created attachment 294235 [details]
Patch

Comment 37 WebKit Commit Bot 2016-11-09 10:20:13 PST

Attachment 294235 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 38 WebKit Commit Bot 2016-11-09 11:35:01 PST

Comment on attachment 294235 [details]
Patch

Clearing flags on attachment: 294235

Committed r208455: <http://trac.webkit.org/changeset/208455>

Comment 39 WebKit Commit Bot 2016-11-09 11:35:07 PST

All reviewed patches have been landed.  Closing bug.

Comment 40 Alexey Proskuryakov 2016-11-16 17:02:03 PST

This caused bug 164572.