Bug 164475

Summary: [EFL] Suppress build warning in generated Geoclue2Interface.c
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, tonikitoo
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159128    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2016-11-07 04:50:36 PST
https://trac.webkit.org/changeset/202479 disabled werror for this file, but I think this noisy build output isn't good, let's suppress this warning. [1270/5284] Building C object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/Geoclue2Interface.c.o DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client': DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent': DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start': DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop': DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter] It turned out, GTK already suppresses this warning: https://bugs.webkit.org/show_bug.cgi?id=163733#c3
Attachments
Patch (1.67 KB, patch)
2016-11-07 04:51 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-11-07 04:51:37 PST
Created attachment 294054 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-14 04:25:32 PST
Comment on attachment 294054 [details] Patch Clearing flags on attachment: 294054 Committed r208677: <http://trac.webkit.org/changeset/208677>
WebKit Commit Bot
Comment 3 2016-11-14 04:25:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.