Bug 164396

Summary: Add an assertion to diagnose stress GC bots test failures
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Description Flags
Adds an assertion
Patch for landing none

Description Ryosuke Niwa 2016-11-03 19:39:02 PDT
Somehow we're hitting an assertion in ElementQueue::invokeAll.
As far as I understand, this assertion should only fire when ElementQueue::add is called while we're inside invokeAll.
Add an assertion to figure out where this is happening because I can't reproduce locally.

Comment 1 Ryosuke Niwa 2016-11-03 19:52:27 PDT
Created attachment 293847 [details]
Adds an assertion
Comment 2 Antti Koivisto 2016-11-03 19:55:14 PDT
Comment on attachment 293847 [details]
Adds an assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=293847&action=review

> Source/WebCore/dom/CustomElementReactionQueue.cpp:210
> +    ASSERT(!m_invoking);
> +#endif

Don't need ASSERT_DISABLED test here.
Comment 3 Ryosuke Niwa 2016-11-03 20:01:39 PDT
Created attachment 293848 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-11-03 20:49:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 293848 [details]:

inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: sbarati@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2016-11-03 20:49:50 PDT
Comment on attachment 293848 [details]
Patch for landing

Clearing flags on attachment: 293848

Committed r208366: <http://trac.webkit.org/changeset/208366>
Comment 6 WebKit Commit Bot 2016-11-03 20:49:55 PDT
All reviewed patches have been landed.  Closing bug.