Summary: | Add an assertion to diagnose stress GC bots test failures | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, esprehn+autocc, kangil.han | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 154907 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-11-03 19:39:02 PDT
Created attachment 293847 [details]
Adds an assertion
Comment on attachment 293847 [details] Adds an assertion View in context: https://bugs.webkit.org/attachment.cgi?id=293847&action=review > Source/WebCore/dom/CustomElementReactionQueue.cpp:210 > +#if !ASSERT_DISABLED > + ASSERT(!m_invoking); > +#endif Don't need ASSERT_DISABLED test here. Created attachment 293848 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 293848 [details]: inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: sbarati@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 293848 [details] Patch for landing Clearing flags on attachment: 293848 Committed r208366: <http://trac.webkit.org/changeset/208366> All reviewed patches have been landed. Closing bug. |