Bug 164311 – REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding

[Andy Estes]

<rdar://problem/26995374>

[Andy Estes]

Created attachment 293669 [details]
Patch

[Tim Horton]

Comment on attachment 293669 [details]
Patch

This seems like one of those mistakes we've probably made in other places; should we look around and fix others?

[Andy Estes]

(In reply to comment #3)
> Comment on attachment 293669 [details]
> Patch
> 
> This seems like one of those mistakes we've probably made in other places;
> should we look around and fix others?

Yeah, we should. I filed https://bugs.webkit.org/show_bug.cgi?id=164330 about this.

[Andy Estes]

Created attachment 293679 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 293679 [details]
Patch

Clearing flags on attachment: 293679

Committed r208295: <http://trac.webkit.org/changeset/208295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 293669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293669&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:345
> -        filenames.uncheckedAppend(fileURL.fileSystemRepresentation);
> +        filenames.uncheckedAppend(String::fromUTF8(fileURL.fileSystemRepresentation));

Instead of:

    String::fromUTF8(fileURL.fileSystemRepresentation)

I believe we can, and should, just use:

    fileURL.path

[Andy Estes]

*** Bug 166473 has been marked as a duplicate of this bug. ***