Bug 164093

Summary: Regression(r203601): Caused crashes in iBooks
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, commit-queue, darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160071    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-10-27 16:30:31 PDT
r203601 caused crashes in iBooks.

The change made the parameter non-nullable. In ObjC bindings, the approach at the time was to throw an exception (and therefore crash) when passing nil.
Comment 1 Chris Dumez 2016-10-27 16:31:01 PDT
<rdar://problem/28745634>
Comment 2 Chris Dumez 2016-10-27 16:34:42 PDT
Created attachment 293076 [details]
Patch
Comment 3 Chris Dumez 2016-10-27 17:04:16 PDT
Created attachment 293081 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-27 20:58:46 PDT
Comment on attachment 293081 [details]
Patch

Clearing flags on attachment: 293081

Committed r208027: <http://trac.webkit.org/changeset/208027>
Comment 5 WebKit Commit Bot 2016-10-27 20:58:51 PDT
All reviewed patches have been landed.  Closing bug.