Bug 163816

Summary: [Web ID] Overload resolution is wrong if one of the types is a nullable union
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, esprehn+autocc, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163764    
Bug Blocks: 163795    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-21 16:13:20 PDT
Overload resolution is wrong if one of the types is a nullable union. This is because we never consider the union type itself, only its subtypes. Therefore, we checks if any of the union's subtypes are nullable but we fail to check if the union itself is nullable. I noticed this while working on Bug 163795.
Attachments
Patch (15.02 KB, patch)
2016-10-21 17:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-21 17:25:37 PDT
Created attachment 292438 [details] Patch
Chris Dumez
Comment 2 2016-10-21 17:29:24 PDT
Comment on attachment 292438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292438&action=review > Source/WebCore/bindings/scripts/test/TestObj.idl:311 > + void overloadWithNullableUnion((TestObj or TestNode)? objectOrNode); Passing null here would previously call the overload below instead of this one.
WebKit Commit Bot
Comment 3 2016-10-21 22:30:11 PDT
Comment on attachment 292438 [details] Patch Clearing flags on attachment: 292438 Committed r207705: <http://trac.webkit.org/changeset/207705>
WebKit Commit Bot
Comment 4 2016-10-21 22:30:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.