| Summary: | WebGLRenderingContextBase.bufferData() should use a union instead of overloading | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 163764, 163816 | ||||||||
| Bug Blocks: | 163791 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2016-10-21 10:02:05 PDT
Created attachment 292501 [details]
Patch
Comment on attachment 292501 [details]
Patch
Looks good, but GTK and EFL builds are failing.
Created attachment 292504 [details]
Patch
Comment on attachment 292504 [details] Patch Clearing flags on attachment: 292504 Committed r207715: <http://trac.webkit.org/changeset/207715> All reviewed patches have been landed. Closing bug. Comment on attachment 292504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292504&action=review > Source/JavaScriptCore/runtime/JSArrayBuffer.h:80 > +inline ArrayBuffer* JSArrayBuffer::toWrapped(JSValue value) > +{ > + return toArrayBuffer(value); > +} > + FYI, this method, and its goal of reducing special handling of ArrayBuffer contradicts https://bugs.webkit.org/show_bug.cgi?id=163986 (SharedArrayBuffer), which requires us to increase the special handling of ArrayBuffer. It's going to be necessary for clients of ArrayBuffer to state at the point of use if they are OK with the buffer being shared so that we don't accidentally use a shared array buffer in a context where it would not be safe to do so. |