Bug 163731

Summary:

[Modern Media Controls] Media Controller: Placard support

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, rniwa, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch for landing	none
Patch for landing	none

Antoine Quint

Reported 2016-10-20 08:05:36 PDT

We need to show the Airplay and picture-in-picture placards when the media is played in Airplay or PiP mode.

Attachments
Patch (26.37 KB, patch) 2016-10-20 08:07 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (64.82 KB, patch) 2016-10-31 12:02 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (930.15 KB, application/zip) 2016-10-31 12:49 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.52 MB, application/zip) 2016-10-31 13:19 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (deleted) 2016-10-31 13:42 PDT, Build Bot	no flags	Details
Patch (16.28 KB, patch) 2016-11-01 12:09 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (17.28 KB, patch) 2016-11-01 13:58 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (16.61 KB, patch) 2016-11-01 14:10 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-10-20 08:06:14 PDT

<rdar://problem/28869598>

Antoine Quint

Comment 2 2016-10-20 08:07:35 PDT

Created attachment 292191 [details] Patch

Antoine Quint

Comment 3 2016-10-20 08:08:13 PDT

Tests aren't ready yet but the source can be reviewed already.

Antoine Quint

Comment 4 2016-10-31 12:02:38 PDT

Created attachment 293448 [details] Patch

Build Bot

Comment 5 2016-10-31 12:49:39 PDT

Comment on attachment 293448 [details] Patch Attachment 293448 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2412841 New failing tests: media/modern-media-controls/airplay-placard/airplay-placard.html media/modern-media-controls/placard-support/placard-support-airplay.html media/modern-media-controls/placard-support/placard-support-pip.html

Build Bot

Comment 6 2016-10-31 12:49:42 PDT

Created attachment 293453 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-10-31 13:19:05 PDT

Comment on attachment 293448 [details] Patch Attachment 293448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2413166 New failing tests: media/modern-media-controls/airplay-placard/airplay-placard.html media/modern-media-controls/placard-support/placard-support-airplay.html media/modern-media-controls/placard-support/placard-support-pip.html

Build Bot

Comment 8 2016-10-31 13:19:07 PDT

Created attachment 293458 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-10-31 13:42:09 PDT

Comment on attachment 293448 [details] Patch Attachment 293448 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2413203 New failing tests: media/modern-media-controls/airplay-placard/airplay-placard.html media/modern-media-controls/placard-support/placard-support-airplay.html media/modern-media-controls/placard-support/placard-support-pip.html

Build Bot

Comment 10 2016-10-31 13:42:13 PDT

Created attachment 293461 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antoine Quint

Comment 11 2016-10-31 15:16:35 PDT

https://trac.webkit.org/changeset/208182

Ryan Haddad

Comment 12 2016-10-31 16:55:21 PDT

Both of the tests added with this change time out on macOS Release: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r208182%20(1189)/results.html

Ryan Haddad

Comment 13 2016-10-31 16:56:47 PDT

Reverted r208182 for reason: Both of the tests added with this change time out on macOS Release. Committed r208195: <http://trac.webkit.org/changeset/208195>

Ryan Haddad

Comment 14 2016-10-31 17:15:38 PDT

(In reply to comment #7) > Comment on attachment 293448 [details] > Patch > > Attachment 293448 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/2413166 > > New failing tests: > media/modern-media-controls/airplay-placard/airplay-placard.html > media/modern-media-controls/placard-support/placard-support-airplay.html > media/modern-media-controls/placard-support/placard-support-pip.html It looks like EWS predicted this before the patch was landed.

Antoine Quint

Comment 15 2016-11-01 12:09:17 PDT

Created attachment 293564 [details] Patch

Antoine Quint

Comment 16 2016-11-01 13:58:54 PDT

Created attachment 293586 [details] Patch for landing

WebKit Commit Bot

Comment 17 2016-11-01 14:00:16 PDT

Comment on attachment 293586 [details] Patch for landing Rejecting attachment 293586 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 293586, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing file LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html patching file LayoutTests/platform/ios-simulator/TestExpectations patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1195. Hunk #2 succeeded at 1451 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2445831

Antoine Quint

Comment 18 2016-11-01 14:10:45 PDT

Created attachment 293593 [details] Patch for landing

WebKit Commit Bot

Comment 19 2016-11-01 14:46:52 PDT

Comment on attachment 293593 [details] Patch for landing Clearing flags on attachment: 293593 Committed r208242: <http://trac.webkit.org/changeset/208242>

WebKit Commit Bot

Comment 20 2016-11-01 14:46:57 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 21 2016-11-01 15:50:56 PDT

media/modern-media-controls/placard-support/placard-support-airplay.html is timing out See https://bugs.webkit.org/show_bug.cgi?id=164298

Note You need to log in before you can comment on or make changes to this bug.