Bug 163547

Summary: [iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, dbates, dino, ryanhaddad, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162801    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-10-17 09:41:36 PDT
Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates.
Attachments
Patch (2.89 KB, patch)
2016-10-17 09:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-17 09:43:30 PDT
Created attachment 291825 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-17 09:45:50 PDT
Attachment 291825 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2016-10-17 10:51:09 PDT
Comment on attachment 291825 [details] Patch Clearing flags on attachment: 291825 Committed r207413: <http://trac.webkit.org/changeset/207413>
WebKit Commit Bot
Comment 4 2016-10-17 10:51:14 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 5 2016-10-17 11:02:26 PDT
Can we write tests for this change?
Chris Dumez
Comment 6 2016-10-17 11:03:27 PDT
(In reply to comment #5) > Can we write tests for this change? Sure, this is my next patch (see https://bugs.webkit.org/show_bug.cgi?id=162801) which is blocked by this bug.
Ryan Haddad
Comment 7 2016-10-18 15:36:20 PDT
Reverted r207413 for reason: This change broke iOS builds. Committed r207494: <http://trac.webkit.org/changeset/207494>
Ryan Haddad
Comment 8 2016-10-18 15:37:12 PDT
<rdar://problem/28833585>
Chris Dumez
Comment 9 2016-10-25 09:37:24 PDT
Reverted r207494 for reason: iOS SDK has been updated on the bots now so rollout the rollout Committed r207823: <http://trac.webkit.org/changeset/207823>
Chris Dumez
Comment 10 2016-11-07 09:36:19 PST
Relanded in r207823.
Note You need to log in before you can comment on or make changes to this bug.