| Summary: | [iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, dbates, dino, ryanhaddad, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 162801 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2016-10-17 09:41:36 PDT
Created attachment 291825 [details]
Patch
Attachment 291825 [details] did not pass style-queue:
ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:0: Use #pragma once header guard. [build/header_guard] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291825 [details] Patch Clearing flags on attachment: 291825 Committed r207413: <http://trac.webkit.org/changeset/207413> All reviewed patches have been landed. Closing bug. Can we write tests for this change? (In reply to comment #5) > Can we write tests for this change? Sure, this is my next patch (see https://bugs.webkit.org/show_bug.cgi?id=162801) which is blocked by this bug. Reverted r207413 for reason: This change broke iOS builds. Committed r207494: <http://trac.webkit.org/changeset/207494> Reverted r207494 for reason: iOS SDK has been updated on the bots now so rollout the rollout Committed r207823: <http://trac.webkit.org/changeset/207823> Relanded in r207823. |