Bug 163387

Summary:

[Modern Media Controls] MediaControls base class

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

163356

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch for landing	none

Antoine Quint

Reported 2016-10-13 06:59:14 PDT

Now that we have the basic buttons and sliders to build media controls, we need objects to display them for various configurations. At first, we need a MediaControls base class that we will then subclass for specific configurations (macOS inline, macOS fullscreen, iOS inline).

Attachments
Patch (24.54 KB, patch) 2016-10-13 07:04 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.34 MB, application/zip) 2016-10-13 07:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.84 MB, application/zip) 2016-10-13 08:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (1.07 MB, application/zip) 2016-10-13 08:13 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.97 MB, application/zip) 2016-10-13 08:30 PDT, Build Bot	no flags	Details
Patch for landing (24.65 KB, patch) 2016-10-13 11:51 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-10-13 06:59:42 PDT

<rdar://problem/28753955>

Antoine Quint

Comment 2 2016-10-13 07:04:53 PDT

Created attachment 291479 [details] Patch

Antoine Quint

Comment 3 2016-10-13 07:05:24 PDT

Tests will fail until https://bugs.webkit.org/show_bug.cgi?id=163356 lands.

Build Bot

Comment 4 2016-10-13 07:45:59 PDT

Comment on attachment 291479 [details] Patch Attachment 291479 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2277058 New failing tests: media/modern-media-controls/media-controls/media-controls-start-button.html media/modern-media-controls/media-controls/media-controls-constructor.html media/modern-media-controls/media-controls/media-controls-placard.html

Build Bot

Comment 5 2016-10-13 07:46:00 PDT

Created attachment 291480 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-10-13 08:11:43 PDT

Comment on attachment 291479 [details] Patch Attachment 291479 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2277132 New failing tests: media/modern-media-controls/media-controls/media-controls-start-button.html media/modern-media-controls/media-controls/media-controls-constructor.html media/modern-media-controls/media-controls/media-controls-placard.html

Build Bot

Comment 7 2016-10-13 08:11:46 PDT

Created attachment 291481 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-10-13 08:13:05 PDT

Comment on attachment 291479 [details] Patch Attachment 291479 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2277177 New failing tests: media/modern-media-controls/media-controls/media-controls-start-button.html media/modern-media-controls/media-controls/media-controls-constructor.html media/modern-media-controls/media-controls/media-controls-placard.html

Build Bot

Comment 9 2016-10-13 08:13:07 PDT

Created attachment 291482 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-10-13 08:30:16 PDT

Comment on attachment 291479 [details] Patch Attachment 291479 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2277155 New failing tests: media/modern-media-controls/media-controls/media-controls-start-button.html media/modern-media-controls/media-controls/media-controls-constructor.html media/modern-media-controls/media-controls/media-controls-placard.html

Build Bot

Comment 11 2016-10-13 08:30:19 PDT

Created attachment 291483 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antoine Quint

Comment 12 2016-10-13 11:51:25 PDT

Created attachment 291502 [details] Patch for landing

WebKit Commit Bot

Comment 13 2016-10-13 12:05:07 PDT

Comment on attachment 291502 [details] Patch for landing Clearing flags on attachment: 291502 Committed r207299: <http://trac.webkit.org/changeset/207299>

WebKit Commit Bot

Comment 14 2016-10-13 12:05:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.