Bug 162957

Summary: WebRTC: Add support for the icecandidate event in MediaEndpointPeerConnection
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: alex, commit-queue, eric.carlson, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211, 162961    
Description Flags
Proposed patch
eric.carlson: review+
Patch for landing
Updated patch (for landing) none

Description Adam Bergkvist 2016-10-05 00:13:39 PDT
The WebRTC backend dispatches locally gathered ICE candidates to the RTCPeerConnection object via the 'icecandidate' event.
Comment 1 Adam Bergkvist 2016-10-05 00:52:34 PDT
Created attachment 290696 [details]
Proposed patch
Comment 2 Eric Carlson 2016-10-05 20:18:57 PDT
Comment on attachment 290696 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290696&action=review

> Source/WebCore/ChangeLog:12
> +        Add API to Internals to emulate WebRTC platform events. Such as dispatching a set of ICE

Nit: "platform events. Such as" -> "platform events, such as"
Comment 3 Adam Bergkvist 2016-10-05 23:48:54 PDT
Created attachment 290783 [details]
Patch for landing
Comment 4 Adam Bergkvist 2016-10-06 01:23:43 PDT
Created attachment 290794 [details]
Updated patch (for landing)
Comment 5 Adam Bergkvist 2016-10-06 01:24:14 PDT
Thanks for reviewing. Fixed nits in patch for landing.
Comment 6 WebKit Commit Bot 2016-10-06 01:57:19 PDT
Comment on attachment 290794 [details]
Updated patch (for landing)

Clearing flags on attachment: 290794

Committed r206856: <http://trac.webkit.org/changeset/206856>