Bug 162925

Summary: [Win][Direct2D] Add Direct2D CMake rules
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dino, mmaxfield, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161817    
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2016-10-04 11:09:24 PDT
This patch updates the build rules on Windows to support an optional "Direct2D" build.
Attachments
Patch (18.59 KB, patch)
2016-10-05 20:40 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.73 KB, patch)
2016-10-06 10:15 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-10-05 20:40:20 PDT
Created attachment 290777 [details] Patch
Alex Christensen
Comment 2 2016-10-06 09:05:10 PDT
Comment on attachment 290777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review > Source/WebCore/ChangeLog:26 > + * PlatformAppleWinCACG.cmake: Added. > + * PlatformWinDirect2D.cmake: Added. I don't think we want more files in Source/WebCore just for this. I think we should put things in PlatformWin and PlatformAppleWin with conditionals. > Source/WebCore/page/win/FrameWinDirect2D.cpp:36 > +#include "NotImplemented.h" This isn't used in this patch.
Alex Christensen
Comment 3 2016-10-06 09:14:23 PDT
Comment on attachment 290777 [details] Patch r=me other than that.
Brent Fulgham
Comment 4 2016-10-06 09:58:35 PDT
Comment on attachment 290777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review >> Source/WebCore/ChangeLog:26 >> + * PlatformWinDirect2D.cmake: Added. > > I don't think we want more files in Source/WebCore just for this. I think we should put things in PlatformWin and PlatformAppleWin with conditionals. OK. I'll do it that way. >> Source/WebCore/page/win/FrameWinDirect2D.cpp:36 >> +#include "NotImplemented.h" > > This isn't used in this patch. Its needed in code that was already landed. When I merged from my local machine I missed this line, and since we don't build D2D on EWS (yet) I didn't notice the omission until I synced my local build.
Brent Fulgham
Comment 5 2016-10-06 10:15:03 PDT
Created attachment 290827 [details] Patch for landing
Brent Fulgham
Comment 6 2016-10-06 10:16:08 PDT
Comment on attachment 290827 [details] Patch for landing Patch for landing.
WebKit Commit Bot
Comment 7 2016-10-06 11:04:03 PDT
Comment on attachment 290827 [details] Patch for landing Clearing flags on attachment: 290827 Committed r206871: <http://trac.webkit.org/changeset/206871>
WebKit Commit Bot
Comment 8 2016-10-06 11:04:08 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 9 2016-10-06 13:37:24 PDT
🎉
Note You need to log in before you can comment on or make changes to this bug.