| Summary: | [Win][Direct2D] Add Direct2D CMake rules | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, dino, mmaxfield, pvollan | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 161817 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brent Fulgham
2016-10-04 11:09:24 PDT
Created attachment 290777 [details]
Patch
Comment on attachment 290777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review > Source/WebCore/ChangeLog:26 > + * PlatformAppleWinCACG.cmake: Added. > + * PlatformWinDirect2D.cmake: Added. I don't think we want more files in Source/WebCore just for this. I think we should put things in PlatformWin and PlatformAppleWin with conditionals. > Source/WebCore/page/win/FrameWinDirect2D.cpp:36 > +#include "NotImplemented.h" This isn't used in this patch. Comment on attachment 290777 [details]
Patch
r=me other than that.
Comment on attachment 290777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review >> Source/WebCore/ChangeLog:26 >> + * PlatformWinDirect2D.cmake: Added. > > I don't think we want more files in Source/WebCore just for this. I think we should put things in PlatformWin and PlatformAppleWin with conditionals. OK. I'll do it that way. >> Source/WebCore/page/win/FrameWinDirect2D.cpp:36 >> +#include "NotImplemented.h" > > This isn't used in this patch. Its needed in code that was already landed. When I merged from my local machine I missed this line, and since we don't build D2D on EWS (yet) I didn't notice the omission until I synced my local build. Created attachment 290827 [details]
Patch for landing
Comment on attachment 290827 [details]
Patch for landing
Patch for landing.
Comment on attachment 290827 [details] Patch for landing Clearing flags on attachment: 290827 Committed r206871: <http://trac.webkit.org/changeset/206871> All reviewed patches have been landed. Closing bug. 🎉 |